Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scope in admin-generator #1696

Closed
wants to merge 1 commit into from

Conversation

Ben-Ho
Copy link
Contributor

@Ben-Ho Ben-Ho commented Feb 13, 2024

this is probably not needed and only a temporary backup as existing project-code requires this. project can't be refactored until beginning of april.

@johnnyomair
Copy link
Collaborator

@Ben-Ho should we really review and merge this? Or is this only here for you to use in your project until you've got time to refactor?

@Ben-Ho Ben-Ho removed the request for review from johnnyomair February 22, 2024 07:52
@Ben-Ho
Copy link
Contributor Author

Ben-Ho commented Feb 22, 2024

@Ben-Ho should we really review and merge this? Or is this only here for you to use in your project until you've got time to refactor?

currently I think I'll close this pull-request later on. If I change my mind I'll assign some reviewers 👍

@johnnyomair johnnyomair marked this pull request as draft February 22, 2024 08:35
@Ben-Ho Ben-Ho closed this May 23, 2024
@Ben-Ho Ben-Ho deleted the admin-gen-configurable_add-scope branch May 23, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants